On Sat, 4 Feb 2023 07:42:37 GMT, Julian Waters <jwat...@openjdk.org> wrote:
>> src/java.security.jgss/windows/native/libsspi_bridge/sspi.cpp line 31: >> >>> 29: // This library can be built directly with the following command: >>> 30: // cl -I %OPENJDK%\src\java.security.jgss\share\native\libj2gss\ >>> sspi.cpp >>> 31: // -link -dll -out:sspi_bridge.dll >> >> I think the backslash `` should remain there: it's a command line and `` is >> used to wrap the long line. > > I did think about that too when I first saw it, but the command this is often > run from is the Windows CMD, which does not accept `` to escape to the next > line. MSYS bash does not have the required environment set up outside of > configure time to run `cl` either, but I have not tested with WSL yet. I > suppose one could do the complicated setup required to be able to run this > from the winenv provided bash, but that seems like a lot of hassle, enough > that to me someone trying to compile sspi_bridge.dll by itself wouldn't > really bother with the process. On top of that cl.exe will actually interpret > the backslash as the literal object file `.o` for some weird reason. I've > already pinged the original author of the file @wangweij above to ask for > guidance on this as such I have no objection to the code change. Or maybe you can change it to the windows line extension character `^`. I was using this command for quick recompiling while writing this code, and it's in a cmd.exe window launched with a start menu item named something like "Visual Studio Developing Environment". I wrote it inside here to remind myself if I need to rework on it. ------------- PR: https://git.openjdk.org/jdk/pull/12305
