On Fri, 3 Feb 2023 16:11:21 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Keep the "NAME -> 1.2.3.4" mapping unchanged but modify "1.2.3.4 -> NAME" to
>> "1.2.3.4 -> Name".
>
> Weijun Wang has updated the pull request incrementally with one additional
> commit since the last revision:
>
> impl not necessary
src/java.base/share/classes/sun/security/x509/AlgorithmId.java line 603:
> 601: // add the name->oid and oid->name mappings if
> none exists
> 602: if (KnownOIDs.findMatch(upperStdAlgName) ==
> null) {
> 603: // not override earlier entries if it exists
s/not/do not/
src/java.base/share/classes/sun/security/x509/AlgorithmId.java line 607:
> 605: }
> 606: if (KnownOIDs.findMatch(ostr) == null) {
> 607: // not override earlier entries if it exists
s/not/do not/
test/jdk/sun/security/x509/AlgorithmId/Uppercase.java line 30:
> 28: * @summary AlgorithmId should keep lowercase characters from 3rd party
> providers
> 29: * @modules java.base/sun.security.x509
> 30: * java.base/sun.security.util
Do you need this module?
test/jdk/sun/security/x509/AlgorithmId/Uppercase.java line 55:
> 53: public ProviderImpl() {
> 54: super("ProviderImpl", "1.0", "ProviderImpl");
> 55: // It does not matter if we really provider an implementation
s/provider/provide/
-------------
PR: https://git.openjdk.org/jdk/pull/12410
