On Mon, 6 Feb 2023 16:01:17 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> impl not necessary > > test/jdk/sun/security/x509/AlgorithmId/Uppercase.java line 30: > >> 28: * @summary AlgorithmId should keep lowercase characters from 3rd party >> providers >> 29: * @modules java.base/sun.security.x509 >> 30: * java.base/sun.security.util > > Do you need this module? `AlgorithmId.get(ALG).getOID().toString()` calls `sun.security.util.ObjectIdentifier::toString`. Uppercase.java:46: error: ObjectIdentifier.toString() in package sun.security.util is not accessible Asserts.assertEQ(AlgorithmId.get(ALG).getOID().toString(), OID); ^ (package sun.security.util is declared in module java.base, which does not export it to the unnamed module) ------------- PR: https://git.openjdk.org/jdk/pull/12410