On Fri, 24 Mar 2023 19:02:57 GMT, Vladimir Kozlov <[email protected]> wrote:
>> Cesar Soares Lucas has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Add support for SR'ing some inputs of merges used for field loads
>
> src/hotspot/share/code/debugInfo.hpp line 199:
>
>> 197: // ObjectValue describing an object that was scalar replaced.
>> 198:
>> 199: class ObjectMergeValue: public ScopeValue {
>
> Why you did not make subclass of ObjectValue? You would need to check
> `sv->is_object_merge()` first before `sv->is_object()` in few places. But on
> other hand you don't need to duplicates ObjectValue`s fields and asserts.
Hi @vnkozlov, just FYI. I made the changes that you suggested. Please let me
know what you think.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/12897#discussion_r1158700435
