On Wed, 5 Apr 2023 00:59:29 GMT, Cesar Soares Lucas <cslu...@openjdk.org> wrote:

>> Do you really need the boolean parameter ignore_merges here? 
>> It looks like we can use (safepoints == nullptr) instead?
>
>> It looks like we can use (safepoints == nullptr) instead?
> 
> Yeap. Thanks. I don't know how I missed that.

> With ignore_merges, why we also skip EncodeP or MemBarRelease here?

The EncodeP shouldn't prevent the reduction of Phi because I check how the Phi 
is used.
The MemBarRelease node shouldn't prevent the reduction because once the 
Allocate input to the Phi is set to SR the MemBarRelease node will be removed 
as part of Ideal transformations after EA.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/12897#discussion_r1157910405

Reply via email to