On Wed, 24 May 2023 15:14:26 GMT, Sean Mullan <[email protected]> wrote:
>> Ferenc Rakoczi has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Removed dead code, accepted code style suggestions.
>
> src/java.base/share/classes/sun/security/provider/HSS.java line 695:
>
>> 693: throw new InvalidKeySpecException("key should not be
>> null");
>> 694: }
>> 695: if (key.getFormat().equals("X.509") &&
>
> Would it make sense to also check if `key` is an instance of `HSSPublicKey`?
I don't think so, the check here is not too heavy, it covers that case and it
is called rarely enough that this kind of optimisation would be worthwhile
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/13691#discussion_r1205716056
