On Fri, 27 Oct 2023 20:07:07 GMT, Weijun Wang <[email protected]> wrote:
>> Hai-May Chao has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Change property names to clearly indicate client side and server side
>
> src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 160:
>
>> 158: "jdk.tls.server.maxInboundCertificateChainLength");
>> 159: if (inboundClientLen == null || inboundClientLen < 0) {
>> 160: inboundClientLen = 8;
>
> The logic is little too long for me to digest. I wonder if we can just
> rewrite the line above to
>
> inboundClientLen = globalPropSet ? maxCertificateChainLength : 8;
>
> then there is no need for `serverPropSet` and `clientPropSet`.
Hmm, but how does this work? The inbound properties override the global
property if both are set.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/15163#discussion_r1375007615
