On Mon, 12 Feb 2024 08:34:24 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
> Currently we have 2 GCMParameters classes in java.base, one in > sun.security.util package, the other in com.sun.crypto.provider. > > This PR merges the changes from the sun.security.util copy into > com.sun.crypto.provider, and removes the sun.security.util class. > > As far as I could tell, the sun.security.util class was added to avoid > exporting com.sun.crypto.provider to jdk.crypto.cryptoki. The export was > introduced later in > [JDK-8259319](https://bugs.openjdk.org/browse/JDK-8259319), so there's no > reason to keep both copies. > > No new tests. Tier1-3 tests continue to pass. alright then, I'll make the changes shortly. Should I change the copyright and the `@since 13` tag? Given that the files are almost identical, it feels wrong to have 2 different copyrights, and `@since` doesn't make much sense on a non-public SPI class. ------------- PR Comment: https://git.openjdk.org/jdk/pull/17802#issuecomment-1942032930
