On Tue, 13 Feb 2024 20:58:17 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Currently we have 2 GCMParameters classes in java.base, one in >> sun.security.util package, the other in com.sun.crypto.provider. >> >> This PR merges the changes from the sun.security.util copy into >> com.sun.crypto.provider, and removes the sun.security.util class. >> >> As far as I could tell, the sun.security.util class was added to avoid >> exporting com.sun.crypto.provider to jdk.crypto.cryptoki. The export was >> introduced later in >> [JDK-8259319](https://bugs.openjdk.org/browse/JDK-8259319), so there's no >> reason to keep both copies. >> >> No new tests. Tier1-3 tests continue to pass. > > Daniel Jeliński has updated the pull request incrementally with one > additional commit since the last revision: > > Remove the other GCMParameters Marked as reviewed by weijun (Reviewer). This looks clean. @valeriepeng, what do you think? ------------- PR Review: https://git.openjdk.org/jdk/pull/17802#pullrequestreview-1878960573 PR Comment: https://git.openjdk.org/jdk/pull/17802#issuecomment-1942605501
