On Thu, 9 May 2024 19:40:31 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Prajwal Kumaraswamy has updated the pull request with a new target base due >> to a merge or a rebase. The incremental webrev excludes the unrelated >> changes brought in by the merge/rebase. The pull request contains three >> additional commits since the last revision: >> >> - Refactored code >> - Merge remote-tracking branch 'origin/master' into JDK-8261433 >> - 8261433: Better pkcs11 performance for >> libpkcs11:C_EncryptInit/libpkcs11:C_DecryptInit > > src/jdk.crypto.cryptoki/share/classes/sun/security/pkcs11/wrapper/PKCS11.java > line 807: > >> 805: * @param hKey the handle of the encryption key >> 806: * (PKCS#11 param: CK_OBJECT_HANDLE hKey) >> 807: * @param useNormativeVerFirst which version of params to use first > > nit: maybe "whether to use normative version of GCM parameters first"? Same > goes for C_GCMDecryptInitWithRetry(...) Done ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18425#discussion_r1596408687
