On Mon, 13 May 2024 19:01:09 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). > > Kevin Driver has updated the pull request incrementally with one additional > commit since the last revision: > > code review comments src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 81: > 79: * if the initialization parameters are inappropriate for this > {@code KDFSpi} > 80: */ > 81: protected HkdfKeyDerivation(AlgorithmParameterSpec algParameterSpec) I suggest throwing an exception if params is not null. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1599064113
