On Mon, 13 May 2024 20:48:31 GMT, Weijun Wang <[email protected]> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code review comments
>
> src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java
> line 81:
>
>> 79: * if the initialization parameters are inappropriate for this
>> {@code KDFSpi}
>> 80: */
>> 81: protected HkdfKeyDerivation(AlgorithmParameterSpec algParameterSpec)
>
> I suggest throwing an exception if params is not null.
What would we say in the javadoc? We throw `null` temporarily, since there are
no known algorithms that support parameters? We may not want to issue a
change/fix if this becomes no longer the case (ie- some provider besides us
offers one).
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1599193734
