On Mon, 13 May 2024 13:56:17 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> re-enable preview annotations
>
> src/java.base/share/classes/javax/crypto/KDF.java line 314:
>
>> 312: Objects.requireNonNull(algorithm, "null algorithm name");
>> 313: try {
>> 314: Instance instance = GetInstance.getInstance("KDF",
>> KDFSpi.class,
>
> I think you can call `JceSecurity.getInstance` here, and then you don't need
> lines 318-322. Same comment applies to other `getInstance` methods.
I think we cannot call `JceSecurity.getInstance` here, since there is an
additional parameter.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18924#discussion_r1600227540
