On Thu, 25 Jul 2024 20:00:53 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with two >> additional commits since the last revision: >> >> - bad test check >> - internal PEMRecord optimization > > src/java.base/share/classes/javax/crypto/EncryptedPrivateKeyInfo.java line > 325: > >> 323: * @param key the PrivateKey object to encrypt. >> 324: * @param password the password used in the PBE encryption. >> 325: * @param algorithm the algorithm to encrypt with. > > Do you need to tell what algorithms can be used here? Is it something like > "PBEwithAESandWhatever"? Do you need to add a link to somewhere in the > Standard Names Doc? This is something I hadn't circled back for documentation. I didn't put the Standard Names Doc is not usable unfortunately. The doc says the algorithm name format, but makes you look through an IETF document to find the algorithms. Either the Standard Names Doc should be updated or something else needs to be done to make the algorithm names more obvious. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1692472596
