On Thu, 25 Jul 2024 20:07:55 GMT, Weijun Wang <[email protected]> wrote:
>> Anthony Scarpino has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - bad test check
>> - internal PEMRecord optimization
>
> src/java.base/share/classes/sun/security/util/Pem.java line 104:
>
>> 102: public static final String DEFAULT_ALGO;
>> 103: static {
>> 104: DEFAULT_ALGO =
>> Security.getProperty("jdk.epkcs8.defaultAlgorithm");
>
> Do you want to fail if the security property is not defined?
I assuming you are suggesting to check when the property is used? Having an
error message when loading would probably be a customer call generator.
A NoSuchAlgorithmException when doing encryption. I suppose a message during
encryption usage could say the property is not set.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1695882735
