On Thu, 25 Jul 2024 20:48:33 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request incrementally with two
>> additional commits since the last revision:
>>
>> - bad test check
>> - internal PEMRecord optimization
>
> src/java.base/share/classes/java/security/PEMEncoder.java line 224:
>
>> 222: try {
>> 223: os.writeBytes(Base64.getMimeEncoder(64,
>> Pem.LINESEPARATOR)
>> 224: .encode(c.getEncoded()));
>
> Should we add a `os.writeBytes(Pem.LINESEPARATOR)` like for keys here? Same
> with CRL.
This code is out of date now
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/17543#discussion_r1697430629
