On Mon, 29 Jul 2024 17:56:44 GMT, Daniel Jeliński <djelin...@openjdk.org> wrote:
>> Anthony Scarpino has updated the pull request with a new target base due to >> a merge or a rebase. The pull request now contains 21 commits: >> >> - Rework TLSBase for better testing >> - Tests working >> - Merge branch 'master' into nst-multi >> - new changes >> - remove frag issue >> - Comments, remove thread, set NST default to 1, allow 0 >> - comment cleanup >> - Merge branch 'master' into nst-multi >> - copyright & cleanup >> - oops BAOS >> - ... and 11 more: https://git.openjdk.org/jdk/compare/3796fdfc...35bfe799 > > src/java.base/share/classes/sun/security/util/Cache.java line 454: > >> 452: case QueueCacheEntry<K, V> qe -> { >> 453: lock.lock(); >> 454: qe.putValue(newEntry); > > this will add the entry to queue even if canQueue is false. What are the > implications of that? True, it should handle this case. This actually simplifies the code by adding the `!canQueue` check to the maxQueueSize check. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/19465#discussion_r1700799905
