On Thu, 8 Aug 2024 01:51:51 GMT, Valerie Peng <valer...@openjdk.org> wrote:

>> src/java.base/share/classes/javax/crypto/KDF.java line 259:
>> 
>>> 257:             throw new NoSuchAlgorithmException(
>>> 258:                 "Received an InvalidAlgorithmParameterException. Does 
>>> this "
>>> 259:                 + "algorithm require KDFParameters?", e);
>> 
>> Change the question to something like "No implementation found using null 
>> KDFParameters"?
>
> Same goes for line 291-292.

Like the above method, I suggested "KDFParameters must be specified."   I'm 
fine if you choose Valerie's suggestion

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1714356805

Reply via email to