On Fri, 16 Aug 2024 21:05:23 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Why do the null check on {@code provider} here? For consistency sake, since
>> both {@code algorithm} and {@code provider} are checked for non-null inside
>> {@code getInstance(String, KDFParameters, String), you should either check
>> both for non-null or leave it to the 3-arg getInstance() call.
>
> Addressed in
> https://github.com/openjdk/jdk/pull/20301/commits/c6f491cd05c76088e6431b2ba9d4ab42b29e4055.
> Please indicate if this is resolved.
How about the "may" => "should" change?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1720473835
