On Tue, 13 Aug 2024 15:24:11 GMT, Kevin Driver <kdri...@openjdk.org> wrote:

>> Introduce an API for Key Derivation Functions (KDFs), which are 
>> cryptographic algorithms for deriving additional keys from a secret key and 
>> other data. See [JEP 478](https://openjdk.org/jeps/478).
>> 
>> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924).
>
> Kevin Driver has updated the pull request incrementally with one additional 
> commit since the last revision:
> 
>   addressed several review comments, namely: - renaming the getParameters 
> method - renaming the AlgorithmParameterSpec object - address some javadoc 
> exception messages - add some information to KDF class private constructor 
> javadocs - other general cleanup

test/jdk/com/sun/crypto/provider/KDF/TestHKDF.java line 79:

> 77: 
> 78:     public static final List<TestData> testList = new 
> LinkedList<TestData>() {{
> 79:         add(new TestData("RFC 5689 Test Case 1", "HKDFWithHmacSHA256",

typo: "5689" should be "5869". Sames goes to other test datum.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1720340574

Reply via email to