On Wed, 21 Aug 2024 20:58:35 GMT, Valerie Peng <valer...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> addresses delayed provider selection where parameters are involved
>
> test/jdk/com/sun/crypto/provider/KDF/TestHKDF.java line 187:
>
>> 185: actualPRK, testData.info,
>> 186: testData.outLen);
>> 187: actualOKM = kdfExpand.deriveKey("RAW", kdfParameterSpecExpand);
>
> We use "RAW" for key format, but in this file, it's used as key algorithm.
> Maybe use a standard key algorithm name?
These are "RAW" since the lengths are somewhat arbitrary in the KATs. It's
perhaps a bit misleading to create standard keys with strange output lengths.
Would you prefer "Generic" over "RAW"?
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1729533962
