On Mon, 26 Aug 2024 17:43:31 GMT, Weijun Wang <[email protected]> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> code review comments and test renaming
>
> src/java.base/share/classes/javax/crypto/KDF.java line 317:
>
>> 315: * if no {@code Provider} supports a {@code KDFSpi}
>> implementation for
>> 316: * the specified algorithm
>> 317: * @throws InvalidAlgorithmParameterException
>
> No IAPE is thrown in the current implementation.
This is declared for implementation use. Are you arguing that no implementation
may require it?
> src/java.base/share/classes/javax/crypto/KDF.java line 473:
>
>> 471: * @param alg
>> 472: * the algorithm of the resultant {@code SecretKey} object
>> 473: * @param derivationParameterSpec
>
> I prefer a short name like `input`. I know the type is
> `AlgorithmParameterSpec` but it's actually not parameter.
Acknowledged. `input` is too vague.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1731628819
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1731629746
