On Thu, 29 Aug 2024 14:15:38 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Resolved in >> https://github.com/openjdk/jdk/pull/20301/commits/a65dc9da044297c313e02d698255bad915dc0a10. > > Personally I don't like the "mutate" word. But your sentence is quite > complete now, so I don't have a strong opinion now. `KDFParameter` objects should ideally always be immutable (we should never provide mutable methods on a standard `KDFParameter` subclass), so I agree the word "mutating" is not right, what is being returned in this case is always going to be a new object. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1736860375