On Wed, 28 Aug 2024 20:44:10 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Introduce an API for Key Derivation Functions (KDFs), which are >> cryptographic algorithms for deriving additional keys from a secret key and >> other data. See [JEP 478](https://openjdk.org/jeps/478). >> >> Work was begun in [another PR](https://github.com/openjdk/jdk/pull/18924). > > Kevin Driver has updated the pull request incrementally with two additional > commits since the last revision: > > - consistency with wording for addIKM and addSalt > - another round of code review comments src/java.base/share/classes/com/sun/crypto/provider/HkdfKeyDerivation.java line 147: > 145: // we should be able to combine these Lists of key segments > into > 146: // single SecretKey Objects, unless we were passed something > bogus > 147: // or an unexportable P11 key Still has typo "Objects", should be "object". BTW, I still strongly feel that it can be combined into a byte[] instead of a SecretKey object. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1736940767
