On Tue, 3 Sep 2024 20:39:00 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional >> commit since the last revision: >> >> change impl class to use byte arrays rather than SecretKey objects where >> possible > > test/jdk/com/sun/crypto/provider/KDF/HKDFKnownAnswerTests.java line 86: > >> 84: >> "077709362c2e32df0ddc3f0dc47bba6390b6c73bb50f9c3122ec844ad7c2b3e5", >> 85: >> "3cb25f25faacd57a90434f64d0362f2a2d2d0a90cf1a5a4c5db02d56ecc4c5bf" >> 86: + > > I usually don't see `+` in separate lines. Put it at the end of the previous > line. I think the formatter is doing this for line length adherence. In some cases, the string is already more than the permitted number of characters, so it is bringing the `+` down. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1743996074
