On Sun, 8 Sep 2024 16:22:31 GMT, Alan Bateman <[email protected]> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> updated comments around locking mechanism
>
> src/java.base/share/classes/java/security/KDFParameters.java line 30:
>
>> 28:
>> 29: /**
>> 30: * A specification of {@code KDF} parameters.
>
> A passing comment on KDFPraameters. It doesn't spell out what "KDF" stands
> for, and doesn't seem to link to KDF in the class description.
@AlanBateman: Added in
https://github.com/openjdk/jdk/pull/20301/commits/dc0bd1552ea14adaec4cc8e67d4213826c1b175c.
> src/java.base/share/classes/javax/crypto/KDFSpi.java line 37:
>
>> 35: /**
>> 36: * This class defines the <i>Service Provider Interface</i> (<b>SPI</b>)
>> for the
>> 37: * {@code KDF} class.
>
> KDFSpi is the same, I guess I expected to see "Key Derivation Function" and a
> link to KDF in the first paragraph.
@AlanBateman: Added in
https://github.com/openjdk/jdk/pull/20301/commits/dc0bd1552ea14adaec4cc8e67d4213826c1b175c.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1752658562
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1752658900
