On Fri, 13 Sep 2024 15:22:34 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Updated in >> https://github.com/openjdk/jdk/pull/20301/commits/e7e5b3e5a017c7b7ce6db3c17ea4c1fca27cd901. > > Sorry for another round on this. It's still possible that > `consolidateKeyMaterial` works fine on `ikms` but throws IKE on `salts`, and > this time `inputKeyMaterial` is not cleaned up. > > Also, is it possible that `consolidateKeyMaterial` throws an IAPE directly so > you don't need to catch and wrap? @wangweij: See https://github.com/openjdk/jdk/pull/20301/commits/f279c7ff11c570fdb7307827bfcd86680a862ae6. The exception type will remain the same due to consolidating under the single try block. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1759228623