On Sat, 14 Sep 2024 22:11:21 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> Kevin Driver has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> refine wording on DPS getInstance with params exception
>
> src/java.base/share/classes/javax/crypto/KDF.java line 194:
>
>> 192: * otherwise {@code null} is returned.
>> 193: *
>> 194: * @see <a href="#DelayedProviderSelection">Delayed Provider
>> Selection</a>
>
> Why `@see DPS`? The paragraph above has nothing to do with it.
>
> If you meant the warning not to call it too early (which I think is not
> necessary), why not add the same to the `getProviderName` method?
`@see DPS` is also present in the header/javadoc for `getProviderName`
currently. I don't think I understand that part of your comment.
The intent is to refer the reader to the *entire* DPS selection of the class
specification when calling a method which is affected by DPS.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1761480754
