On Fri, 13 Sep 2024 22:06:17 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> I still think appending to or creating a list is implementation detail. > > I can see your point; however, we are not saying "_L_ist of values", so we > are discussing it in an abstract manner. Let's leave it "as-is", since it can > be interpreted either way. The usage of "list" in specification could imply the `List` API, so it is best to avoid it as this could be interpreted as a requirement of the implementation. See for example the methods in the [`Collections` ](https://docs.oracle.com/en/java/javase/23/docs/api/java.base/java/util/Collections.html) API that operate on `List` objects but use "list" in the specification when referencing it. If you want to be more abstract but still imply some sort of aggregation, I would suggest something like: "The `ikms()` method of the `Extract` or `ExtractThenExpand` object that is subsequently built returns the assembled input keying material as a list of `SecretKey` objects." ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/20301#discussion_r1763983720
