On Fri, 4 Oct 2024 13:05:57 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a
>> merge or a rebase. The incremental webrev excludes the unrelated changes
>> brought in by the merge/rebase. The pull request contains six additional
>> commits since the last revision:
>>
>> - Merge branch 'master' into 8340327
>> - more test, more RAW support, fix a bug on cleaning up getRawBytes output
>> - add support for private class RawKeySpec
>> - ensure key is intact after being used
>> - renames
>> - the fix
>
> src/java.base/share/classes/sun/security/provider/NamedKeyPairGenerator.java
> line 123:
>
>> 121: public void initialize(int keysize, SecureRandom random) {
>> 122: if (keysize != -1) {
>> 123: // Bonus: a chance to provide a SecureRandom without
>
> Is this a TODO because I don't see the code that does this? I would avoid the
> word "Bonus" here.
I just meant user can call `initialize(-1, rand)` to provide a user-defined
`SecureRandom` without touching the parameter set used. Will update the comment.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1788054511
