On Fri, 4 Oct 2024 17:40:39 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/pkcs/NamedPKCS8Key.java line 55:
>>
>>> 53: /// Ctor from family name, parameter set name, raw key bytes.
>>> 54: /// Key bytes won't be cloned, caller must relinquish ownership
>>> 55: public NamedPKCS8Key(String fname, String pname, byte[] h) {
>>
>> This may be a "style" nit, but it might be better to have a name longer than
>> the single-character `h`. I had to refer to the comments to know what this
>> is rather than relying on the variable name to be sufficient.
>
> How about `rawKey`?
Sure. Anything you like that fits what it holds.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1788240541
