On Fri, 4 Oct 2024 16:47:53 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Merge branch 'master' into 8340327 >> - more test, more RAW support, fix a bug on cleaning up getRawBytes output >> - add support for private class RawKeySpec >> - ensure key is intact after being used >> - renames >> - the fix > > src/java.base/share/classes/sun/security/x509/NamedX509Key.java line 46: > >> 44: private final String fname; >> 45: private final transient NamedParameterSpec paramSpec; >> 46: private final byte[] h; > > Can this name be more descriptive? Updated to `rawBytes`. It also matches the `getRawBytes` method name. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1790121803
