On Fri, 4 Oct 2024 16:56:05 GMT, Kevin Driver <kdri...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request with a new target base due to a >> merge or a rebase. The incremental webrev excludes the unrelated changes >> brought in by the merge/rebase. The pull request contains six additional >> commits since the last revision: >> >> - Merge branch 'master' into 8340327 >> - more test, more RAW support, fix a bug on cleaning up getRawBytes output >> - add support for private class RawKeySpec >> - ensure key is intact after being used >> - renames >> - the fix > > test/jdk/sun/security/provider/NamedEdDSA.java line 178: > >> 176: } >> 177: } >> 178: } > > It may be too much overhead, but you could likely do this with `Collections`. I copied these methods from original EdDSA implementation. It's OK in a test, IMHO. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1790154641
