On Tue, 8 Oct 2024 18:46:20 GMT, Sean Mullan <mul...@openjdk.org> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional >> commit since the last revision: >> >> null check as asserts, and better exception messages > > src/java.base/share/classes/sun/security/provider/NamedSignature.java line 63: > >> 61: >> 62: private Object sk2 = null; >> 63: private Object pk2 = null; > > Nit - don't need to set these to null. OK. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1792446518