On Tue, 8 Oct 2024 01:15:49 GMT, Valerie Peng <[email protected]> wrote:
>> Weijun Wang has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> null check as asserts, and better exception messages
>
> src/java.base/share/classes/sun/security/pkcs/NamedPKCS8Key.java line 56:
>
>> 54: public final class NamedPKCS8Key extends PKCS8Key {
>> 55: @Serial
>> 56: private static final long serialVersionUID = 1L;
>
> Well, I didn't find similar serialization handling in this class as in
> `PKCS8Key`. Do we expect (de-)serialization to work or not?
Never mind, I saw the code about serialization not working.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21167#discussion_r1791056156
