On Tue, 15 Oct 2024 17:59:52 GMT, rebarbora-mckvak <d...@openjdk.org> wrote:
>> This fixes the defect described at >> https://bugs.openjdk.org/browse/JDK-8313367 >> >> If the process does not have write permissions, the store is opened as >> read-only (instead of failing). >> >> Please note that permissions to use a certificate in a local machine store >> must be granted - in a management console, select a certificate, right-click >> -> All tasks... -> Manage Private Keys... -> add Full control to user. > > rebarbora-mckvak has updated the pull request incrementally with one > additional commit since the last revision: > > copyright fixed ah, I expected to find the comments in the chat and didn't look at the code... You are right about the open issues - but I personally don't care about the signHash changes. When the author doesn't fix this - what about just merging the initial fix e1a0a22ed6e69a14e35eb90cad4087880e7c0585 and the test case 1eff576e7db9283a92d5388a4865b78e66a47373? ------------- PR Comment: https://git.openjdk.org/jdk/pull/16687#issuecomment-2445121601
