On Fri, 8 Nov 2024 22:16:29 GMT, Weijun Wang <wei...@openjdk.org> wrote:

>> Actually what might be better is when you add the data files later, you 
>> should treat those tests as failures if you can't find the data. I'm worried 
>> about false passes, where the data file gets accidentally removed or 
>> something and the test still passes.
>
> I'll skip if there is nothing to test, either because cannot find the JSON 
> files or none of the algorithms is supported.

Ok, I still think you should add something that knows how many data files there 
are, and doesn't pass unless all of them are processed/tested. I'm ok if you do 
that later.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1835111694

Reply via email to