On Fri, 8 Nov 2024 22:01:11 GMT, Weijun Wang <wei...@openjdk.org> wrote:
>> test/jdk/sun/security/provider/acvp/Launcher.java line 36: >> >>> 34: */ >>> 35: >>> 36: /// This test runs on `internalProjection.json`-style files generated >> >> Is there a reason you didn't put all these comments (or a copy of them) in >> the README file instead? It seems like a better place for it. The README >> doesn't help me understand how to run the tests. > > The README file is inside a sub-directory and I created it before adding > `acvp.md` so that directory is not empty (Git does not support empty > directories). I'd like to keep the text here and remove that README, Or, if > you believe a standalone README is better, I can move the README out of > `data` and put it here in the same level as this file, and move these text > there. Maybe just remove the README, it kind of threw me off as it didn't contain anything much useful. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/21548#discussion_r1835100912
