On Thu, 14 Nov 2024 00:20:06 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> Sean Coffey has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> keep expand option and add test coverage
>
> src/java.base/share/classes/sun/security/ssl/SSLLogger.java line 90:
>
>> 88: && property.length() == 10
>> 89: &&
>> !Character.isLetterOrDigit(property.charAt(3))
>> 90: && property.endsWith("expand"));
>
> I believe this is not needed, and the code can be simplified using the same
> style as I remember from the earlier stack. I'll look at this tomorrow.
With the current definition in the JSSE docs, `sslexpandhandshakeverbose` is an
acceptable value, as are the tokens in any order. e.g.
`sslverbosehandshakeexpand` or
`ssl|moohaha|handshake2354432verbose@#%^%SeanWasHere,keygen`. This code here
is position dependent and won't allow it.
This approach needs a rethink. Maybe an `EnumSet` initialized here that
contains the active, known `ssl` options, that is then checked during the
`isOn(checkPoints)`? Just a thought.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r1843068934
