On Tue, 19 Nov 2024 12:09:07 GMT, Sean Coffey <coff...@openjdk.org> wrote:
>> src/java.base/share/classes/sun/security/ssl/DTLSInputRecord.java line 1075:
>>
>>> 1073: if (!isDesired) {
>>> 1074: // Too old to use, discard this retransmitted
>>> record
>>> 1075: if (SSLLogger.isOn &&
>>> SSLLogger.isOn("ssl,handshake,verbose")) {
>>
>> <=80 chars, please. Noticed this in several files/places.
>
> thanks for reminder. I've fixed up some lines that had gone a few chars over
> the 80 limit. I thought we'd become a bit more lenient on this advice. It got
> me curious about the current state of src code in the the security base.
> Seems like we've many src files that go well over the 80 char limit, some for
> legitimate reasons, some not.
>
> some data on top 25 offending files in just sun.security in case it's of
> interest:
>
>
> ------------------------------------------------------------------------
> Rank Width File
> ------------------------------------------------------------------------
> 1 159 src/java.base/share/classes/sun/security/util/CurveDB.java
> 2 158
> src/java.base/share/classes/sun/security/tools/keytool/Main.java
> 3 140
> src/java.base/share/classes/sun/security/util/math/intpoly/MontgomeryIntegerPolynomialP256.java
> 4 137
> src/java.base/share/classes/sun/security/x509/IPAddressName.java
> 5 129
> src/java.base/share/classes/sun/security/x509/EDIPartyName.java
> 6 121 src/java.base/share/classes/sun/security/x509/X400Address.java
> 7 120 src/java.base/share/classes/sun/security/util/Debug.java
> 8 117
> src/java.base/share/classes/sun/security/ssl/CertificateRequest.java
> 9 117
> src/java.base/share/classes/sun/security/ssl/CertificateMessage.java
> 10 116
> src/java.base/share/classes/sun/security/util/SecurityProperties.java
> 11 116 src/java.base/share/classes/sun/security/ssl/SSLLogger.java
> 12 111 src/java.base/share/classes/sun/security/util/ECUtil.java
> 13 110
> src/java.base/share/classes/sun/security/x509/X509CertImpl.java
> 14 110
> src/java.base/share/classes/sun/security/util/TlsChannelBinding.java
> 15 110
> src/java.base/share/classes/sun/security/ssl/SSLSocketImpl.java
> 16 109 src/java.base/share/classes/sun/security/x509/OIDName.java
> 17 109 src/java.base/share/classes/sun/security/x509/DNSName.java
> 18 109
> src/java.base/share/classes/sun/security/rsa/RSAKeyFactory.java
> 19 108 src/java.base/share/classes/sun/security/x509/X509CRLImpl.java
> 20 108
> src/java.base/share/classes/sun/security/util/SignatureUtil.java
> 21 108
> src/java.base/share/classes/sun/security/util/SignatureFileVerifier.java
> 22 108
> src/java.base/share/classes/sun/security/util/ObjectIdentifier.java
> 23 108 src/java.base/share/classes/sun/security/pkcs/SignerInfo.java
> 24 107 src/java.base/share/cl...
Doesn't surprise me. We've tried to keep the JSSE relatively clean, it sure
makes side-by-side comparisons a lot easier for no real work.
Thanks for cleaning.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/18764#discussion_r1849061349
