On Tue, 19 Nov 2024 07:56:55 GMT, Alan Bateman <[email protected]> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8344446: Revert spurious inclusion of SCTP changes
>
> src/java.base/share/classes/java/io/FileInputStream.java line 136:
>
>> 134: if (name == null) {
>> 135: throw new NullPointerException();
>> 136: }
>
> I assume (old) L133-139 can be replaced with `String name = file.getPath()`,
> the explicit check that name is null goes away with the SM check.
See 9fbcb82.
> src/java.base/share/classes/java/io/FileOutputStream.java line 205:
>
>> 203: if (name == null) {
>> 204: throw new NullPointerException();
>> 205: }
>
> Same comment as the FOS constructor.
See 9fbcb82.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22219#discussion_r1848715568
PR Review Comment: https://git.openjdk.org/jdk/pull/22219#discussion_r1848715621
