On Mon, 25 Nov 2024 19:04:21 GMT, Alan Bateman <al...@openjdk.org> wrote:
>> Brian Burkhalter has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> 8344882: Do not create Cleaner for temporary buffers
>
> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 77:
>
>> 75: static final boolean UNALIGNED = Bits.unaligned();
>> 76:
>> 77: private @Stable boolean temporary; // defaults to false
>
> Is this used now?
No. I removed it in a version I did not check in but forgot here.
> src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java line 73:
>
>> 71: * Used by {@code sun.nio.ch.Util}.
>> 72: */
>> 73: ByteBuffer allocateDirectTemporary(int cap);
>
> In Util, the phrase used is "temporary buffer and the methods are named like
> getTemporaryDirectBuffer. The SharedSecrets transposes the words, don't know
> if that was intended or not.
It was intended but I think they should match. I'll change the on in
JavaNioAccess.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22339#discussion_r1857215085
PR Review Comment: https://git.openjdk.org/jdk/pull/22339#discussion_r1857215672
