On Mon, 25 Nov 2024 19:10:17 GMT, Brian Burkhalter <b...@openjdk.org> wrote:
>> src/java.base/share/classes/java/nio/Direct-X-Buffer.java.template line 77: >> >>> 75: static final boolean UNALIGNED = Bits.unaligned(); >>> 76: >>> 77: private @Stable boolean temporary; // defaults to false >> >> Is this used now? > > No. I removed it in a version I did not check in but forgot here. Changed in [9d84aa9](https://github.com/openjdk/jdk/pull/22339/commits/9d84aa9cfd718265c72e26eff9434f8817d25d80). >> src/java.base/share/classes/jdk/internal/access/JavaNioAccess.java line 73: >> >>> 71: * Used by {@code sun.nio.ch.Util}. >>> 72: */ >>> 73: ByteBuffer allocateDirectTemporary(int cap); >> >> In Util, the phrase used is "temporary buffer and the methods are named like >> getTemporaryDirectBuffer. The SharedSecrets transposes the words, don't know >> if that was intended or not. > > It was intended but I think they should match. I'll change the on in > JavaNioAccess. Changed in https://github.com/openjdk/jdk/pull/22339/commits/9d84aa9cfd718265c72e26eff9434f8817d25d80. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22339#discussion_r1857224962 PR Review Comment: https://git.openjdk.org/jdk/pull/22339#discussion_r1857225219
