On Tue, 26 Nov 2024 01:07:51 GMT, Bradford Wetmore <wetm...@openjdk.org> wrote:
>> Artur Barashev has updated the pull request incrementally with one
>> additional commit since the last revision:
>>
>> Remove timeout as JTREG has a default test timeout
>
> test/jdk/sun/security/ssl/SSLCipher/SSLSocketNoServerHelloClientShutdown.java
> line 101:
>
>> 99: log(e.toString());
>> 100: } finally {
>> 101: serverLatch.countDown();
>
> There should be a `latch.await()` at the `getInputStream()` above, as we want
> to stall the start of the server handshaking until all of the client data has
> been generated. (i.e. ClientHello/Alerts X 2).
You could also have a different latch here for `join`ing, but that's not as
important as the one above.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22263#discussion_r1857535588
