On Wed, 27 Nov 2024 13:46:51 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:
>> Volodymyr Paprotski has updated the pull request incrementally with one >> additional commit since the last revision: >> >> fix date > > src/java.base/share/classes/com/sun/crypto/provider/CounterMode.java line 57: > >> 55: >> 56: // chunkSize is a multiple of block size and used to divide up >> 57: // input data to trigger the intrinsic. > > This comment looks incorrect, a method marked as an intrinsic is always > inline expanded by C2 compile during parsing or during incremental inlining > if -XX:+InlineIncrement is used. > > I guess what you intend here is triggering an OSR compilation of loop by C2 > compiler which in turn trigger intrinsic since C1 never intrinsifies crypto > APIs For CRC32 digest computation we do support intrinsic at interpreter and c1 compiler level to overcome such warmup related penalties. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22300#discussion_r1860698309
