On Wed, 27 Nov 2024 15:10:09 GMT, Jatin Bhateja <jbhat...@openjdk.org> wrote:
>> Agree with @theRealAph , loop induces safe point on back edges which gives >> opportunity to gc epochs. > >> As Andrew points out, giving an intrinsic lots of data, 'backdoors/breaks' a >> lot of existing algorithms.. from GC not happening because of no safepoint >> inside the intrinsic, to OSR.. >> >> .. and (what I believe to be issue for performance here) the call count >> (CompilationThreshold) to get the intrinsic to compile (well, the callee) in >> the first place. Though as I pointed in the original issue, I am not >> entirely convinced it was the call count that got the intrinsic back in; >> experimentally, chunking got the 'outer intrinsic' to compile. (There is an >> inner intrinsic that works on 16 byte chunks) > > Please update the comments in the code accordingly. Not sure what about the comment needs to be updated. Maybe provide a suggestion? Also, please have a look at the original issue, we had a similar discussion about this same comment and this was the result. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22300#discussion_r1860841172
