On Wed, 27 Nov 2024 01:47:16 GMT, Hai-May Chao <[email protected]> wrote:
>> Sean Mullan has updated the pull request incrementally with one additional
>> commit since the last revision:
>>
>> Fix infinite loop which was causing a few test failures.
>
> src/java.base/share/classes/java/security/KeyStore.java line 2091:
>
>> 2089: }
>> 2090: } catch (Exception e) {
>> 2091: oldException = e;
>
> The updated KeyStore.java code looks good. The run0() is replaced by
> getKeyStore0(). Here it does not do e.getCause(), and it looks like because
> the exception is not wrapped by PrivilegedExceptionAction anymore?
Yes, it now throws the exception directly so there is no need to extract the
cause.
Also, I fixed an infinite loop issue which was causing a couple of regression
tests to fail. See
https://github.com/openjdk/jdk/pull/22401/commits/9ee1967c7883355c4ef9ca20d8e3926ad34914e2
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/22401#discussion_r1860799842
