Re: RFR: 8345060: Remove Security Manager dependencies from java.security.KeyStore and Identity APIs and implementations [v2]

[Hai-May Chao]

On Wed, 27 Nov 2024 14:49:00 GMT, Sean Mullan <mul...@openjdk.org> wrote:

>> src/java.base/share/classes/java/security/KeyStore.java line 2091:
>> 
>>> 2089:                     }
>>> 2090:                 } catch (Exception e) {
>>> 2091:                     oldException = e;
>> 
>> The updated KeyStore.java code looks good. The run0() is replaced by 
>> getKeyStore0(). Here it does not do e.getCause(), and it looks like because 
>> the exception is not wrapped by PrivilegedExceptionAction anymore?
>
> Yes, it now throws the exception directly so there is no need to extract the 
> cause.
> 
> Also, I fixed an infinite loop issue which was causing a couple of regression 
> tests to fail. See 
> https://github.com/openjdk/jdk/pull/22401/commits/9ee1967c7883355c4ef9ca20d8e3926ad34914e2

Thanks for the confirmation. Updated webrev looks good.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22401#discussion_r1860936473