On Tue, 10 Dec 2024 09:31:57 GMT, Jan Lahoda <jlah...@openjdk.org> wrote:
>> Justin Lu has updated the pull request incrementally with four additional >> commits since the last revision: >> >> - implement Severin's review >> >> Co-authored-by: Severin Gehwolf <jerb...@gmail.com> >> - implement Jan's review >> - implement Henry's review >> - implement Weijun's review > > src/jdk.compiler/share/classes/com/sun/tools/javac/resources/compiler_de.properties > line 2302: > >> 2300: compiler.misc.feature.module.imports=Modulimporte >> 2301: >> 2302: compiler.misc.feature.java.base.transitive=Transitiver Modifikator für >> java.base > > Here (and in other languages as well), maybe the `transitive` should remain > intact? `transitive` is what literally appears in the source code - similar > to e.g. `static` or `private`. Fixed in https://github.com/openjdk/jdk/pull/22588/commits/c7bd52950eeb85581aa7dc2c6fbbb02a4f4cff11. I'll check in with the translation team to ask for it not to be translated, I also left a comment for translators. I only provided the fix for _de_, since it is not obvious to me how to correct it for _ja_ or _zh_CN_. Regarding the jshell changes in this PR, they are a result of translation fixes we filed with the translation team from previous drops. You are correct that https://github.com/openjdk/jdk/commit/bcebb0c53c1e4629ebde534e237a86c161130fff did not make it in this PR because it was too late. The localized changes for that commit will come in the RDP2 drop. Regarding the alignment issues in the translated versions, I don't think the translation team would adapt those changes because they are aesthetic, not functional, and this spacing is likely consistent with their l10n language/punctuation rules. If I made this change, we would have to manually adjust these on our side every drop which I don't think would be ideal. ------------- PR Review Comment: https://git.openjdk.org/jdk/pull/22588#discussion_r1878716896
