On Tue, 10 Dec 2024 19:35:21 GMT, Justin Lu <j...@openjdk.org> wrote:
>> Please review this PR which contains the open L10n drop changes for RDP1. >> >> I recommend viewing the improved diffs which are built out by Jon's tool >> here: https://cr.openjdk.org/~jlu/output/. As always, I can not confirm the >> correctness on the quality of the translations themselves. >> >> Generally speaking, observed differences in punctuation can be attributed to >> language rules. Any keys requiring localization that came in after the JDK >> was submitted for translations will be handled in the RDP2 L10n drop. > > Justin Lu has updated the pull request incrementally with four additional > commits since the last revision: > > - implement Severin's review > > Co-authored-by: Severin Gehwolf <jerb...@gmail.com> > - implement Jan's review > - implement Henry's review > - implement Weijun's review Looks like there were additional changes. Good to catch all of these and re-updating each of these spots. Hopefully the translation team can differentiate content between `<>` since similar occurred before. LGTM ------------- Marked as reviewed by dnguyen (Committer). PR Review: https://git.openjdk.org/jdk/pull/22588#pullrequestreview-2500910380
